Skip to content

Update Motors.cpp #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cedricbellec
Copy link

test for direction was wrong and turn method didn't work correctly, now it does !

test for direction was wrong and turn method didn't work correctly, now it does !
@ffissore
Copy link
Contributor

Hi @Cedos14 thanks for your PR. Unfortunately, the file you've modified was using a mac only line terminator (CR) and git couldn't show us a meaningful diff. We have just pushed a fix: now that file uses a LF line terminator but that breaks your PR.
Can you please remake/update it?

@cedricbellec
Copy link
Author

Hi Federico, I just updated it !

Best regards,

Cédric

De : Federico Fissore [mailto:notifications@github.com]
Envoyé : mercredi 22 avril 2015 16:45
À : arduino/Arduino
Cc : Cedos14
Objet : Re: [Arduino] Update Motors.cpp (#3014)

Hi @Cedos14 https://github.com/Cedos14 thanks for your PR. Unfortunately, the file you've modified was using a mac only line terminator (CR) and git couldn't show us a meaningful diff. We have just pushed a fix: now that file uses a LF line terminator but that breaks your PR.
Can you please remake/update it?


Reply to this email directly or view it on GitHub #3014 (comment) . https://github.com/notifications/beacon/ACpYkoTvjKp_4zOtjesW1Bxgf4W7oYEqks5oB6tRgaJpZM4EFhcN.gif

@ffissore
Copy link
Contributor

Thanks. Closing as superseded by #3018

@ffissore ffissore closed this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants